Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): hotfixes for stripe webhook event mapping and reference id retrieval #1368

Merged
merged 4 commits into from
Jun 7, 2023
Merged

fix(router): hotfixes for stripe webhook event mapping and reference id retrieval #1368

merged 4 commits into from
Jun 7, 2023

Conversation

vspecky
Copy link
Member

@vspecky vspecky commented Jun 6, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR makes the following fixes to the Stripe incoming webhooks implementation

  • An Unknown variant was added to the WebhookEventStatus enum to handle unsupported dispute events
  • A bug was fixed in the retrieval of the object reference ID for Payment Intent objects vs Charge and Dispute objects (different fields)
  • Special handling for ACH Credit Transfers was added to processing of the charge.succeeded event
  • Minor robustness and quality of life changes.

Additional Changes

None

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Local testing of Stripe webhooks

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@vspecky vspecky added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 6, 2023
@vspecky vspecky added this to the May 2023 Release milestone Jun 6, 2023
@vspecky vspecky self-assigned this Jun 6, 2023
@vspecky vspecky requested review from a team and ashokkjag as code owners June 6, 2023 14:52
@vspecky vspecky added R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 7, 2023
@tinu-hareesswar tinu-hareesswar added this pull request to the merge queue Jun 7, 2023
Merged via the queue into main with commit 5c2232b Jun 7, 2023
@SanchithHegde SanchithHegde deleted the stripe-webhook-hotfixes branch June 7, 2023 09:36
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@ArjunKarthik ArjunKarthik Awaiting requested review from ArjunKarthik

@jarnura jarnura Awaiting requested review from jarnura

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@vspecky vspecky

Labels
A-core Area: Core flows C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@vspecky @jagan-jaya @Narayanbhat166 @tinu-hareesswar @SanchithHegde